temporary fix on the torchaudio IO#80
Open
YunchaoYang wants to merge 2 commits intofacebookresearch:mainfrom
Open
temporary fix on the torchaudio IO#80YunchaoYang wants to merge 2 commits intofacebookresearch:mainfrom
YunchaoYang wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
artemru
reviewed
Feb 2, 2026
pyproject.toml
Outdated
| "fairseq2>=0.5.2", | ||
| # "mpmath==1.3.0", # I am not sure if we need it | ||
| "numpy>=1.21", | ||
| "scipy>=1.7", |
Contributor
There was a problem hiding this comment.
let's add it only for dev and not as main dep
Author
There was a problem hiding this comment.
Thanks. I already moved scipy to dev dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why ?
The SONAR test suite fails on fairseq2 v0.7 when running with torchaudio 2.9+ because: according to the torchaudio updates. Furture torchaudio will move the IO features to torchcodec.
torchaudio.list_audio_backends()has been removed in torchaudio 2.9.torchaudio.save() and torchaudio.load()I/O APIs have been deprecated and removedHow ?
Since torchaudio is only used in test files (not in production code), this PR implements a temporary fix by replacing torchaudio I/O with scipy.io.wavfile().
Test plan
How did you test your changes ?
Include full command line to help other people reproduce if needed.